Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get repository permissions for a user #528

Merged
merged 6 commits into from
Jul 16, 2020
Merged

Get repository permissions for a user #528

merged 6 commits into from
Jul 16, 2020

Conversation

zachkirlew
Copy link
Contributor

This adds the Get repository permissions for a user repositories API feature

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #528 into master will decrease coverage by 11.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #528       +/-   ##
===========================================
- Coverage   90.45%   78.65%   -11.81%     
===========================================
  Files          24       24               
  Lines         618      623        +5     
  Branches        1        1               
===========================================
- Hits          559      490       -69     
- Misses         59      133       +74     
Impacted Files Coverage Δ
...4s/src/main/scala/github4s/domain/Repository.scala 100.00% <ø> (ø)
github4s/src/main/scala/github4s/Decoders.scala 84.44% <100.00%> (-6.61%) ⬇️
...ithub4s/interpreters/RepositoriesInterpreter.scala 96.15% <100.00%> (+0.20%) ⬆️
github4s/src/main/scala/github4s/Github.scala 0.00% <0.00%> (-100.00%) ⬇️
...ithub4s/src/main/scala/github4s/GithubConfig.scala 0.00% <0.00%> (-100.00%) ⬇️
...4s/src/main/scala/github4s/http/Http4sSyntax.scala 0.00% <0.00%> (-100.00%) ⬇️
...s/src/main/scala/github4s/domain/PullRequest.scala 0.00% <0.00%> (-100.00%) ⬇️
...s/src/main/scala/github4s/modules/GithubAPIs.scala 0.00% <0.00%> (-100.00%) ⬇️
.../src/main/scala/github4s/http/RequestBuilder.scala 0.00% <0.00%> (-100.00%) ⬇️
...ub4s/src/main/scala/github4s/http/HttpClient.scala 16.66% <0.00%> (-70.84%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01206f8...81a5ec5. Read the comment docs.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍 . I just have one minor comment.


package github4s.domain

final case class UserRepoPermission(permission: String, user: User)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can include that in the Repository.scala file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zachkirlew 👍

@BenFradet BenFradet merged commit df9ec5e into 47degrees:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants