-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get repository permissions for a user #528
Get repository permissions for a user #528
Conversation
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
===========================================
- Coverage 90.45% 78.65% -11.81%
===========================================
Files 24 24
Lines 618 623 +5
Branches 1 1
===========================================
- Hits 559 490 -69
- Misses 59 133 +74
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍 . I just have one minor comment.
|
||
package github4s.domain | ||
|
||
final case class UserRepoPermission(permission: String, user: User) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can include that in the Repository.scala
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zachkirlew 👍
This adds the Get repository permissions for a user repositories API feature